Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

593 tet swap operation #595

Closed
wants to merge 5 commits into from
Closed

593 tet swap operation #595

wants to merge 5 commits into from

Conversation

JcDai
Copy link
Collaborator

@JcDai JcDai commented Dec 20, 2023

add edge swap for tetmesh.
modify return data of split and collapse

@JcDai JcDai linked an issue Dec 20, 2023 that may be closed by this pull request
tet swap operation #593
Open
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 406 lines in your changes are missing coverage. Please review.

Comparison is base (25b3f5a) 86.37% compared to head (4361fd1) 82.89%.

Files Patch % Lines
src/wmtk/operations/tet_mesh/TetSplit.cpp 0.00% 65 Missing ⚠️
src/wmtk/optimization/LineSearch.cpp 0.00% 48 Missing ⚠️
src/wmtk/operations/tet_mesh/TetSplitWithTags.cpp 0.00% 47 Missing ⚠️
src/wmtk/operations/tet_mesh/EdgeSplitWithTags.cpp 0.00% 36 Missing ⚠️
...function/utils/DifferentiableFunctionEvaluator.cpp 0.00% 19 Missing ⚠️
...wmtk/function/PerSimplexDifferentiableFunction.cpp 58.13% 18 Missing ⚠️
src/wmtk/function/utils/FunctionEvaluator.cpp 0.00% 17 Missing ⚠️
...nternal/VertexSmoothNewtonMethodWithLineSearch.cpp 0.00% 15 Missing ⚠️
...tri_mesh/VertexSmoothUsingDifferentiableEnergy.cpp 47.82% 12 Missing ⚠️
src/wmtk/operations/tri_mesh/EdgeCollapse.cpp 78.84% 11 Missing ⚠️
... and 37 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   86.37%   82.89%   -3.48%     
==========================================
  Files         220      265      +45     
  Lines        7575     8385     +810     
==========================================
+ Hits         6543     6951     +408     
- Misses       1032     1434     +402
Flag Coverage Δ
wildmeshing 82.89% <72.19%> (-3.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JcDai
Copy link
Collaborator Author

JcDai commented Dec 23, 2023

deprecate after implementing in another branch

@JcDai JcDai closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tet swap operation
1 participant
@JcDai